search

coderefinery / manuals

Diverse operation manuals for CodeRefinery workshops and lesson design.
https://coderefinery.github.io/manuals/
Creative Commons Attribution 4.0 International
9 stars 12 forks source link

Makefile: Turn warnings into errors #197

Closed rkdarst closed 2 years ago

rkdarst commented 2 years ago
rkdarst commented 2 years ago

The other builds (pdf/epub/etc) had more warnings, so I changed it to only fail on HTML errors.

I added the other builds when github actions was new as an experiment, I'm not sure if they are used much. I guess they don't need to be removed but we don't need to fail on them.

rkdarst commented 2 years ago

Hm, I think I would not do this. It can be made a separate action, so that deployment is not blocked if warnings fail. I think that may be better?

bast commented 2 years ago

I agree it would be good to get some feedback during pull request review but it should not block deployment.

rkdarst commented 2 years ago

If a soft warning is enough (not blocking a green check), it should already be visible in the "Files changed" tab under any PR.

rkdarst commented 2 years ago

Seems like this is not needed... closing