requirements: Bugfix with docutils==0.17

coderefinery / sphinx-lesson

Sphinx extension for creating CodeRefinery lessons

https://coderefinery.github.io/sphinx-lesson/

MIT License

15 stars 20 forks source link

requirements: Bugfix with docutils==0.17 #58

Closed rkdarst closed 3 years ago

rkdarst commented 3 years ago

Docutils==0.17 have some changes that break Sphinx rendering. Sphinx is working on it, but in the meantime we can fix some dependencies here until everything gets resolved. This will also fix everyone that depends on us.
This will be removed later, once most Sphinx installations get updated to handle it.
https://github.com/sphinx-doc/sphinx/issues/9061
I propose a release soon after this
Review:
- General check
- comment on release
- comments on the general way we manage the requirements here?

rkdarst commented 3 years ago

This is actually already fixed with upstream docutils (0.5.2), which limits to docutils<0.17. So, I think this can be closed.

blankdots commented 3 years ago

we can and also dependabot to watch dependecies on all repos (where it is possible) so that we don't have to

bast commented 3 years ago

In another repo I hit the same bug and solved it by reordering dependencies, first listing sphinx_rtd_theme.

bast commented 3 years ago

This is actually already fixed with upstream docutils (0.5.2), which limits to docutils<0.17. So, I think this can be closed.

So shall I close and not merge?

rkdarst commented 3 years ago

sphinx_rtd_theme and sphinx have both fixed this for now by pinning docutils<0.17, so it doesn't matter the order of requirements and in most cases we get the right version. There are still chances things can come up until sphinx_rtd_theme fixes some remaining differences, but I think we can close this.