Make PHP require 7.1 so it will match Laravel 5.8's PHP requirement

coderello / laraflash

⚡ Flash messages on steroids.

MIT License

157 stars 18 forks source link

Make PHP require 7.1 so it will match Laravel 5.8's PHP requirement #20

Closed jamesj2 closed 4 years ago

jamesj2 commented 5 years ago

Pull request for #18.

hivokas commented 5 years ago

Some checks were not successful (Scrutinizer — Analysis: No new issues – Tests: failed).

Fix, please.

jamesj2 commented 4 years ago

I'm unsure how to fix this. I'm not familiar with scrutinizer-ci.com. It looks like the lover-file is in the wrong path. Scrutinizer is expecting build/clover-file and the command vendor/bin/phpunit --coverage-clover=clover-file is putting in the root directory. I couldn't find the config for this by searching the code.

hivokas commented 4 years ago

The problem is in PHP version.

This version of PHPUnit is supported on PHP 7.2, PHP 7.3, and PHP 7.4.
You are using PHP 7.1.12 (/home/scrutinizer/.phpenv/versions/7.1.12/bin/php).

hivokas commented 4 years ago

Sorry, I didn't see your last commit. Thanks!

hivokas commented 4 years ago

I've published the release.