search

coderello / laraflash

⚡ Flash messages on steroids.
MIT License
157 stars 18 forks source link

Increase test coverage #6

Closed hivokas closed 6 years ago

mathiasdonoso commented 6 years ago

I want to help with this. Do you use a tool to generate reports for your coverage?

hivokas commented 6 years ago

Glad to hear it. Yes, we use Scrutinizer. Here is the link: https://scrutinizer-ci.com/g/coderello/laraflash/

mathiasdonoso commented 6 years ago

Thanks for your answer!

One more question... what would be the acceptance criteria for this task? (Example: Scrutinizer test coverage >= x%?)

mikeerickson commented 6 years ago

Why not make it 100% since it is a new, relatively small project.

mathiasdonoso commented 6 years ago

ok, seem right to me too.