search

coderello / laravel-shared-data

📦 An easy way to share the data from your backend to the JavaScript.
https://coderello.com/docs/laravel-shared-data/1.0/sharing-data
MIT License
321 stars 22 forks source link

Stable Release #8

Closed hivokas closed 5 years ago

hivokas commented 5 years ago

I'm planning to publish a stable release.

Are there any breaking changes which should be done before this release?

klimov-paul commented 5 years ago

You may consider renaming js_namespace to jsNamespace at config: https://github.com/coderello/laravel-shared-data/blob/master/config/shared-data.php#L15

hivokas commented 5 years ago

I think it's not a good idea. Because Laravel community uses snake case for config keys.

klimov-paul commented 5 years ago

OK, then it is ready for 1.0.0.

hivokas commented 5 years ago

Please, check my latest changes: https://github.com/coderello/laravel-shared-data/commit/1b00097ff05f5d98bd78d2ee33e9df3191a21d85

klimov-paul commented 5 years ago

I would not extract separate method hydrateConfig(). Other changes look fine.

hivokas commented 5 years ago

Well, I've published the release.