There were some macros that were excluded from https://github.com/codereport/jsource/pull/132.
1) I manually comment out the excluded Macro. From my exclude text file.
2) I run my python script
3) Commit change
4) See what breaks.
5) Nothing breaks
a. At least 2 macros were okay for removal after revision of the python script.
b. Some macros were revived in main branch after merging pull requests.
6) The macro was used in another macro in one file.
a. I add the macro back using #define above and #undef below the usage.
b. At least one macro had more than one usage in only one file.
7) The macro was used in multiple files and multiple macros.
a. I put the macro back in the ja.h file.
b. I tried to add a comment saying why the macro wasn't removed.
8) In all cases at least the usage of these macros was reduced to only a handful.
9) I found a few cases where macros were #undef and the next line #define pointing to a new function. I manually removed the few of those I saw.
There were some macros that were excluded from https://github.com/codereport/jsource/pull/132. 1) I manually comment out the excluded Macro. From my exclude text file. 2) I run my python script 3) Commit change 4) See what breaks. 5) Nothing breaks a. At least 2 macros were okay for removal after revision of the python script. b. Some macros were revived in main branch after merging pull requests. 6) The macro was used in another macro in one file. a. I add the macro back using #define above and #undef below the usage. b. At least one macro had more than one usage in only one file. 7) The macro was used in multiple files and multiple macros. a. I put the macro back in the
ja.h
file. b. I tried to add a comment saying why the macro wasn't removed. 8) In all cases at least the usage of these macros was reduced to only a handful. 9) I found a few cases where macros were #undef and the next line #define pointing to a new function. I manually removed the few of those I saw.based on: https://github.com/codereport/jsource/pull/132 related: https://github.com/codereport/jsource/issues/13
This log isn't really accurate. There was a lot of manual work done. After the python script ran. See above.
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\va2ss.c
jsrc\verbs\vbang.c
(^\|[ \t]+\|[^\d\w_])bindd\((?=([^,]+?),([^)]+?)\))
\1jtbindd(jt,
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\k.c
jsrc\verbs\va2ss.c
jsrc\verbs\ve.c
(^\|[ \t]+\|[^\d\w_])dgcd\((?=([^,]+?),([^)]+?)\))
\1jtdgcd(jt,
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\va2ss.c
jsrc\verbs\ve.c
(^\|[ \t]+\|[^\d\w_])dlcm\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\k.c
jsrc\sl.c
jsrc\vq.h
jsrc\adverbs\ai.c
jsrc\adverbs\am.c
jsrc\adverbs\am1.c
jsrc\adverbs\amn.c
jsrc\adverbs\ar.c
jsrc\adverbs\as.c
jsrc\conjunctions\ca.c
jsrc\conjunctions\cc.c
jsrc\conjunctions\cf.c
jsrc\conjunctions\ch.c
jsrc\conjunctions\cp.c
jsrc\conjunctions\cpdtsp.c
jsrc\conjunctions\crs.c
jsrc\conjunctions\cu.c
jsrc\conjunctions\cx.c
jsrc\debugging\d.c
jsrc\parsing\pv.c
jsrc\representations\r.c
jsrc\representations\rl.c
jsrc\verbs\v.c
jsrc\verbs\v0.c
jsrc\verbs\v1.c
jsrc\verbs\v2.c
jsrc\verbs\va2s.c
jsrc\verbs\vb.c
jsrc\verbs\vcat.c
jsrc\verbs\vd.c
jsrc\verbs\vi.c
jsrc\verbs\visp.c
jsrc\verbs\vo.c
jsrc\verbs\vp.c
jsrc\verbs\vrep.c
jsrc\verbs\vs.c
jsrc\verbs\vsb.c
jsrc\verbs\vx.c
jsrc\xenos\xs.c
(^\|[ \t]+\|[^\d\w_])equ\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\v0.c
(^\|[ \t]+\|[^\d\w_])fplus\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\v0.c
(^\|[ \t]+\|[^\d\w_])ftymes\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\va2ss.c
jsrc\verbs\ve.c
(^\|[ \t]+\|[^\d\w_])igcd\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\va2ss.c
(^\|[ \t]+\|[^\d\w_])ilcm\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\va2ss.c
jsrc\verbs\vm.c
(^\|[ \t]+\|[^\d\w_])intpow\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\dtoa.c
jsrc\representations\rt.c
jsrc\verbs\va2.c
jsrc\verbs\vg.c
jsrc\verbs\vi.c
jsrc\verbs\vo.c
jsrc\verbs\vrep.c
jsrc\dtoa.c
jsrc\representations\rt.c
jsrc\verbs\va2.c
jsrc\verbs\vg.c
jsrc\verbs\vi.c
jsrc\verbs\vo.c
jsrc\verbs\vrep.c
(^\|[ \t]+\|[^\d\w_])mult\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\sl.c
jsrc\sn.c
jsrc\adverbs\am1.c
jsrc\adverbs\amn.c
jsrc\adverbs\ao.c
jsrc\adverbs\ap.c
jsrc\adverbs\ar.c
jsrc\adverbs\as.c
jsrc\conjunctions\cc.c
jsrc\conjunctions\cg.c
jsrc\conjunctions\ch.c
jsrc\conjunctions\cx.c
jsrc\debugging\dc.c
jsrc\format\f2.c
jsrc\representations\rl.c
jsrc\representations\rt.c
jsrc\verbs\v0.c
jsrc\verbs\v2.c
jsrc\verbs\vcant.c
jsrc\verbs\vcat.c
jsrc\verbs\vd.c
jsrc\verbs\ve.c
jsrc\verbs\vf.c
jsrc\verbs\vfromsp.c
jsrc\verbs\vi.c
jsrc\verbs\visp.c
jsrc\verbs\vrep.c
jsrc\verbs\vs.c
jsrc\verbs\vt.c
jsrc\verbs\vx.c
jsrc\sl.c
jsrc\sn.c
jsrc\adverbs\am1.c
jsrc\adverbs\amn.c
jsrc\adverbs\ao.c
jsrc\adverbs\ap.c
jsrc\adverbs\ar.c
jsrc\adverbs\as.c
jsrc\conjunctions\cc.c
jsrc\conjunctions\cg.c
jsrc\conjunctions\ch.c
jsrc\conjunctions\cx.c
jsrc\debugging\dc.c
jsrc\format\f2.c
jsrc\representations\rl.c
jsrc\representations\rt.c
jsrc\verbs\v0.c
jsrc\verbs\v2.c
jsrc\verbs\vcant.c
jsrc\verbs\vcat.c
jsrc\verbs\vd.c
jsrc\verbs\ve.c
jsrc\verbs\vf.c
jsrc\verbs\vfromsp.c
jsrc\verbs\vi.c
jsrc\verbs\visp.c
jsrc\verbs\vrep.c
jsrc\verbs\vs.c
jsrc\verbs\vt.c
jsrc\verbs\vx.c
(^\|[ \t]+\|[^\d\w_])over\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\va2ss.c
jsrc\verbs\vm.c
(^\|[ \t]+\|[^\d\w_])pospow\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\v0.c
jsrc\verbs\vgauss.c
jsrc\verbs\vq.c
(^\|[ \t]+\|[^\d\w_])qdiv\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vq.c
(^\|[ \t]+\|[^\d\w_])qgcd\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ap.c
jsrc\verbs\v0.c
jsrc\verbs\vgauss.c
jsrc\verbs\vq.c
jsrc\words\wn.c
(^\|[ \t]+\|[^\d\w_])qminus\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ao.c
jsrc\adverbs\ap.c
jsrc\verbs\v0.c
jsrc\words\wn.c
(^\|[ \t]+\|[^\d\w_])qplus\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ai.c
jsrc\adverbs\ar.c
jsrc\conjunctions\cc.c
jsrc\conjunctions\cip.c
jsrc\conjunctions\cpdtsp.c
jsrc\conjunctions\cu.c
jsrc\parsing\pv.c
jsrc\verbs\vf.c
jsrc\verbs\vm.c
jsrc\xenos\xb.c
jsrc\xenos\xfmt.c
(^\|[ \t]+\|[^\d\w_])qq\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ao.c
jsrc\verbs\v0.c
jsrc\verbs\vgauss.c
jsrc\verbs\vq.c
(^\|[ \t]+\|[^\d\w_])qtymes\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\ve.c
(^\|[ \t]+\|[^\d\w_])remdd\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vrand.c
(^\|[ \t]+\|[^\d\w_])roll2\((?=([^,]+?),([^)]+?)\))
jsrc\verbs\vrand.c
(^\|[ \t]+\|[^\d\w_])roll2\s*\((?=([^,]+?),([^)]+?)\))
jsrc\verbs\vrand.c
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vrand.c
(^\|[ \t]+\|[^\d\w_])rollany\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\k.c
jsrc\vq.h
jsrc\vx.h
jsrc\adverbs\ao.c
jsrc\format\f2.c
jsrc\verbs\v0.c
jsrc\verbs\v2.c
jsrc\verbs\vgcomp.c
jsrc\verbs\vq.c
jsrc\verbs\vx.c
(^\|[ \t]+\|[^\d\w_])xcompare\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vq.c
jsrc\verbs\vx.c
(^\|[ \t]+\|[^\d\w_])xgcd\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vq.c
(^\|[ \t]+\|[^\d\w_])xlcm\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\k.c
jsrc\adverbs\ap.c
jsrc\verbs\v2.c
jsrc\verbs\vq.c
jsrc\verbs\vx.c
(^\|[ \t]+\|[^\d\w_])xminus\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ao.c
jsrc\adverbs\ap.c
jsrc\format\f2.c
jsrc\verbs\v0.c
jsrc\verbs\vq.c
jsrc\verbs\vx.c
(^\|[ \t]+\|[^\d\w_])xplus\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\k.c
jsrc\conjunctions\ca.c
jsrc\format\f2.c
jsrc\verbs\v2.c
(^\|[ \t]+\|[^\d\w_])xpow\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\v2.c
jsrc\verbs\vx.c
(^\|[ \t]+\|[^\d\w_])xrem\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\k.c
jsrc\vq.h
jsrc\vx.h
jsrc\adverbs\ao.c
jsrc\format\f2.c
jsrc\verbs\v2.c
jsrc\verbs\vq.c
jsrc\verbs\vx.c
(^\|[ \t]+\|[^\d\w_])xtymes\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ap.c
jsrc\verbs\v0.c
jsrc\verbs\vbang.c
jsrc\verbs\vgauss.c
jsrc\verbs\vz.c
jsrc\words\wn.c
(^\|[ \t]+\|[^\d\w_])zdiv\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vi.c
(^\|[ \t]+\|[^\d\w_])zeq\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vz.c
(^\|[ \t]+\|[^\d\w_])zgcd\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ap.c
jsrc\verbs\v0.c
jsrc\verbs\vbang.c
jsrc\verbs\vgauss.c
jsrc\verbs\vz.c
(^\|[ \t]+\|[^\d\w_])zminus\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ao.c
jsrc\adverbs\ap.c
jsrc\verbs\v0.c
jsrc\verbs\vbang.c
jsrc\verbs\vz.c
jsrc\words\wn.c
(^\|[ \t]+\|[^\d\w_])zplus\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\v0.c
jsrc\verbs\vbang.c
jsrc\words\wn.c
(^\|[ \t]+\|[^\d\w_])zpow\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\verbs\vz.c
(^\|[ \t]+\|[^\d\w_])zrem\s*\((?=([^,]+?),([^)]+?)\))
jsrc\ja.h
(#define\s+([\w\d]+)\(([^,]+),([^),]+)\)\s+(jt[\d\w]+)\(jt,\(\3\),\(\4\)\))
jsrc\adverbs\ao.c
jsrc\adverbs\ap.c
jsrc\verbs\v0.c
jsrc\verbs\vbang.c
jsrc\verbs\vgauss.c
jsrc\verbs\vz.c
jsrc\words\wn.c
(^\|[ \t]+\|[^\d\w_])ztymes\s*\((?=([^,]+?),([^)]+?)\))