search

codereport / jsource

J Language Source Code. Livestream links ⬇️
https://www.youtube.com/playlist?list=PLVFrD1dmDdvfVhYLU_iKkV67X9XqCJLWe
Other
38 stars 20 forks source link

Move len variable in jeload.cpp #182

Closed herwinw closed 3 years ago

herwinw commented 3 years ago

This is an application of "ES.21: Reduce scope": By moving the definition inside the idef statement, compiling the code on platforms other than MACH sill completely remove this unused variable.

The change works fine on my linux install, but it should be validated on a mac.

juntuu commented 3 years ago

works on osx as well, I did and tested (almost) same refactoring here

herwinw commented 3 years ago

I didn't pay that much attention to that change (since it broke the CI), but it looks like it contains a lot of cleanups that are unrelated to the filesystem change and could be split to a separate PR.