codereport / jsource

J Language Source Code. Livestream links ⬇️
https://www.youtube.com/playlist?list=PLVFrD1dmDdvfVhYLU_iKkV67X9XqCJLWe
Other
38 stars 20 forks source link

Refactor `xcol` #84

Closed codereport closed 3 years ago

codereport commented 3 years ago

In jsrc/verbs/monadic/tally.cpp:

[[nodiscard]] auto
jttally(J jt, array w) -> array {
    array const z = make_scalar_integer(jt, item_count(w));
    return w->tproxy.t & extended_precision_or_rational() ? xco1(z) : z;  // TODO: xcol
}
juntuu commented 3 years ago

The example is outdated, also xco1 should go away as xnum support is removed, so this issue might not be relevant anymore.