search

coderespawn / dock-spawn

Dock Spawn is a web based dock layout engine that aids in creating flexible user interfaces by enabling panels to be docked on the screen similar to Visual Studio IDE
http://dockspawn.com
MIT License
255 stars 76 forks source link

Update deprecated getters and setters #4

Closed MariusVolkhart closed 11 years ago

MariusVolkhart commented 11 years ago

The Element abstract class had some changes made to it that deprecated the old way of calling getters and setters. The new way has a "$dom_" prefix.

This commit updates these calls for lib and for the IDE sample.

coderespawn commented 11 years ago

Hello Marius, Thanks for your support!

As per the recent build release notes, it looks like the client* and offset* attributes has been converted to rects.
So the correct mapping would be:

element.offsetLeft  <=>  element.offset.left
element.offsetWidth  <=>  element.offset.width
element.clientTop  <=>  element.client.top
element.clientHeight  <=>  element.client.height

mouseEvent.offsetX <=> mouseEvent.offset.x
mouseEvent.offsetY <=> mouseEvent.offset.y

$dom_* seem to be internal keywords and will probably be removed in the future. Previous versions of dart SDK showed deprecated warnings for them

Can you make the necessary changes? Also, please update the AUTHORS file with your name

Thanks.

MariusVolkhart commented 11 years ago

Hi Ali,

Awesome library here! I wanted to thank you for you encouraging feedback and information - it makes me want to continue contributing to open-source projects.

Best regards, Marius

coderespawn commented 11 years ago

Thanks!