search

codereverser / casparser-isin

ISIN database for casparser
MIT License
6 stars 7 forks source link

Missing funds in the database #5

Closed ganeshs closed 3 years ago

ganeshs commented 3 years ago

The below funds seem to be missing or has wrong ids:

Missing: FTI915-XXXXXX Franklin India Ultra Short Bond Fund- Super Inst. Plan-Segregated Portfolio 1 (erstwhile 8.25% Vodafone Idea Ltd-10jul20-Daily Dividend Option) - Daily - IDCW# Payout

Wrong amc_code: expected "036" vs actual "36" FTI036-XXXXX Franklin India Prima Fund - GROWTH

Couldn't figure out what's wrong here but the ISIN is not showing up in the parsed output H60-HDFC Low Duration Fund - Regular Plan - Monthly IDCW# (formerly HDFC Cash Management Fund - Treasury Advantage Plan) - Reinvest

codereverser commented 3 years ago

Let me have a look at the first two..

regarding the third, can you please post partial screenshots from the CAS file with the scheme? like image and the partial json data from the library output like 

{
   "scheme":"Aditya Birla Sun Life Floating Rate Fund - Growth-Regular Plan",
   "advisor":"WEALTH",
   "rta_code":"B152IG",
   "type":"DEBT",
   "rta":"CAMS",
   "isin":"INF209K01MG9",
   "amfi":"122644"
}
ganeshs commented 3 years ago

The third one is a reinvest which is not in the datbase. the database has "hdfc low duration fund - retail - regular plan - monthly idcw payout" but not the reinvest

codereverser commented 3 years ago

found some issues with the db creation process. shall fix them asap.

codereverser commented 3 years ago

The HDFC one is a bit weird. According to the scheme codes provided by hdfc at List of scheme codes (external) , 60 is the code for dividend payout option while 60D is for the reinvest option.

need to tweak the search algorithm to handle special cases like this.

codereverser commented 3 years ago

Franklin Templeton funds are going to be managed by CAMS from next Monday (July 19th) onwards, as per https://www.franklintempletonindia.com/investor/customer-services/account-services/transition-to-cams

So it may be better to wait and see if the missing schemes' info can be scraped from CAMS directly which is more open than the current FTAMIL RTA.

codereverser commented 3 years ago

@ganeshs I've added some "hacks" for handling these schemes in #6 . can you please review and see if it works for you?

ganeshs commented 3 years ago

@codereverser the fix introduces regression issues. Added my comments to the PR

codereverser commented 3 years ago

Damn. It looks complex.. Let me work on a better solution.

Does it fix the issues with Franklin funds, btw?

ganeshs commented 3 years ago

Yes, Franklin seems to work.