search

coderforlife / ms-compress

Open source implementations of Microsoft compression algorithms
205 stars 46 forks source link

Avoid ODR violations. #23

Closed nemequ closed 8 years ago

nemequ commented 8 years ago

GCC 5.2 with LTO will emit warnings when linking due to ODR violations which occur across translation units.

For an example of the problems this causes, see https://travis-ci.org/quixdb/squash/jobs/89297023 (note that I have -Werror on in CI; this is typically a warning not an error).

coderforlife commented 8 years ago

Thanks for changing this and for the PR.