search

coderholic / django-cities

Countries and cities of the world for Django projects
MIT License
927 stars 371 forks source link

Not adding all cities #124

Closed mbaragiola closed 6 years ago

mbaragiola commented 8 years ago

Hello,

I've encountered the following problem: Cities that are loaded in geonames.org, are not being loaded in my database.

For instance, the city of San Lorenzo, Santa Fe, Argentina has a population of 46.000, exists at geonames.org[0] but it isn't loaded to my database. This is just one case, there are many more.

Is this a bug or a misconfiguration of mine? I used default settings and then I tried explicitly setting both CITIES_IGNORE_EMPTY_REGIONS = False and CITIES_IGNORE_EMPTY_REGIONS = True, achieving the same result.

[0] http://www.geonames.org/search.html?q=San+Lorenzo%2C+Santa+Fe&country=AR

blag commented 8 years ago

Which San Lorenzo are you missing? The PPL (populated place) or the PPLA2 (seat of a second-order administrative division), or both?

blag commented 8 years ago

@mbaragiola Did you ever figure out if you were missing San Lorenzo the populated place (PPL) or San Lorenzo the second order administrative division (PPLA2)?

mbaragiola commented 7 years ago

@blag I'm so sorry, somehow I didn't see your reply.

What I was missing was San Lorenzo PPL.

blag commented 7 years ago

I'll try to look into this later this week or next week. Ping me if I forget!

blag commented 7 years ago

@mbaragiola I just pushed version 0.5 to PyPI, which contains a bunch of fixes, including a bunch of new tests. Please upgrade to that version, rerun the import script, and check for the San Lorenzo PPL. If it's still an issue, I'll create a test for it and fix it.

Also, please see the testing section of the README to turn on debug logging so I can get a detailed report of what the import script did. Thanks!

blag commented 6 years ago

I'm going to close this due to inactivity. But if this isn't fixed in version 0.5 (and later) please post a comment back here and I will reopen this issue. Thanks!