search

coderholic / django-cities

Countries and cities of the world for Django projects
MIT License
927 stars 371 forks source link

added test project #128

Closed blag closed 8 years ago

blag commented 8 years ago

What I did:

  1. Updated @imposeren's PR #84 to merge cleanly with HEAD
  2. Updated the Travis and Tox settings to only test with currently supported versions of Python and Django (currently: Python 2.7, 3.3 - 3.5 and Django 1.7 - 1.10, with some exclusions - see .travis.yml)
  3. Fixed a few things in the code and made sure the tests passed

@coderholic To get the Travis tests working automatically for PRs (including this one, I think), you'll need to do some configuring:

  1. Login to Travis, authorize it to access your GitHub account, and go to your Travis profile page
  2. Toggle the switch next to coderholic/django-cities
  3. Go to the settings page for (your upstream/fork of) the project, and set the TRAVIS_LOGGER_NAME environment variable to tests (you can also flip the "Display value in build log" to ON because the value isn't sensitive and it may help a contributor debug any failing tests)
  4. Make sure "Build pushes" and "Build pull requests" toggles are switched to ON

I would do all of that myself but Travis needs to add itself to the Github project settings and I can't adjust them for your project (only for my fork).

I'll merge this in once that's all done.

Thanks! 😄

Closes #84; might fix #127.

coderholic commented 8 years ago

Thanks for the detailed steps! I've done them all, and the travis details page is now available at: https://travis-ci.org/coderholic/django-cities - anything else you need me to do?

blag commented 8 years ago

@coderholic: Nope, everything is looking good. Thanks!