coderholic / django-cities

Countries and cities of the world for Django projects
MIT License
921 stars 375 forks source link

Where does Central America continent is? #134

Closed erwinfeser closed 7 years ago

erwinfeser commented 7 years ago

North, Central and South America are not really continents (entire America is), anyway I can see Central America countries but they are loaded as North America ones, which is wrong. All countries between Mexico and Colombia (not inclusive) and Caribbean islands belong to Central America.

coderholic commented 7 years ago

From https://en.wikipedia.org/wiki/Central_America:

Central America is the southernmost, isthmian portion of the North American continent

From https://en.wikipedia.org/wiki/Continent:

Ordered from largest in size to smallest, they are: Asia, Africa, North America, South America, Antarctica, Europe, and Australia.

In addition to that, we just import the data from geonames.org, we don't define it.

blag commented 7 years ago

@erwinfeser Believe it or not, there really isn't a universal standard for what constitutes a continent. Check out this section of the Wikipedia page on Continents - sometimes North and South America are considered one continent, sometimes they're not. And to further compound the issue, different continent models are taught in different regions of the world!

But note that in every single continent model, Central America is considered part of North America.

And as @coderholic noted, we only take data from geonames.org - that's the appropriate place to take this discussion.

coderholic commented 7 years ago

That's correct. Central America isn't a continent. From https://en.wikipedia.org/wiki/Central_America:

Central America is the southernmost, isthmian portion of the North American continent.

On 21 October 2016 at 11:06, Erwin Feser notifications@github.com wrote:

I can see Central America countries but they are loaded as North America ones.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/coderholic/django-cities/issues/134, or mute the thread https://github.com/notifications/unsubscribe-auth/AABl31A1z5Lob7KOvQKpr3ls_IKoWZ8gks5q2P8MgaJpZM4KddXj .