search

coderholic / django-cities

Countries and cities of the world for Django projects
MIT License
920 stars 374 forks source link

Remove slug from PostalCode #151

Closed erwinfeser closed 7 years ago

erwinfeser commented 7 years ago

I could not find the utility of having slug field in postal code model. Better than this would be to create a new migration

blag commented 7 years ago

I'm closing this without merging because I want to have slugs in my models, and I don't think I'm alone.

I have fixed unicode issues for slugs, added tests, and fixed Python import issues in #147 (the more-tests branch). I'll probably be merging that into master and pushing a release. I only mention it because you might be interested in overriding the slugify function to return a blank slug. See my comment in #148 for more information. And I'll add proper documentation for that functionality before I merge it in.

Thanks!