search

coderholic / django-cities

Countries and cities of the world for Django projects
MIT License
920 stars 374 forks source link

'BaseCommand' has no attribute 'option_list' #153

Closed ogonbat closed 7 years ago

ogonbat commented 7 years ago

Hi All

i have installed this fantastic package into a django project django version: 1.10.4 i use a virtualenv with python 2.7.3

So when i launch this command

python manage.py cities --import=all

the command return:

File "manage.py", line 22, in <module> execute_from_command_line(sys.argv) File "/Users/me/bcscuba/lib/python2.7/site-packages/django/core/management/__init__.py", line 367, in execute_from_command_line utility.execute() File "/Users/me/bcscuba/lib/python2.7/site-packages/django/core/management/__init__.py", line 359, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/Users/me/bcscuba/lib/python2.7/site-packages/django/core/management/__init__.py", line 208, in fetch_command klass = load_command_class(app_name, subcommand) File "/Users/me/bcscuba/lib/python2.7/site-packages/django/core/management/__init__.py", line 40, in load_command_class module = import_module('%s.management.commands.%s' % (app_name, name)) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/Users/me/bcscuba/lib/python2.7/site-packages/cities/management/commands/cities.py", line 50, in <module> class Command(BaseCommand): File "/Users/me/bcscuba/lib/python2.7/site-packages/cities/management/commands/cities.py", line 55, in Command option_list = BaseCommand.option_list + ( AttributeError: type object 'BaseCommand' has no attribute 'option_list'

what is wrong? thanks in advance

blag commented 7 years ago

This was fixed in #132, but that fix created more issues. I have fixed those issues in the more-tests branch (pull #147), and I'm current waiting for it to be tested completely (see the comments in #148), then I'll merge it into master and push a new version to PyPI.

Until that time, please use the code in the more-tests branch to minimize issues.

Furthermore, this issue has been reported three previous times - please search for your issue before creating a new one. Thanks! 😄

blag commented 7 years ago

I just merged the more-tests branch into master and pushed the release to PyPI as version 0.5, so you should be able to simply:

pip install --upgrade django-cities

to fix this issue.

Thank you for reporting this issue, even if it was a duplicate. And please don't hesitate to report any other issues, submit feature requests, or ask questions. I'll try to help you as best I can.