search

coderholic / django-cities

Countries and cities of the world for Django projects
MIT License
920 stars 374 forks source link

blank=True for alt_names #166

Closed erwinfeser closed 2 years ago

erwinfeser commented 7 years ago

It would better if we allow alt_names is blank in order to add more cities from admin panel.

blag commented 6 years ago

If you change models, please add a database migration for users.

Also, this breaks for Django 1.10+, and I've updated the Travis config file in master to test Django 1.11 and 2.0.

I've updated the Travis configuration to test Django 1.11 and 2.0.

Please git rebase against master, add database migrations, and ensure it doesn't break more recent Django builds. Then I would be interested in merging it.

Also, consider that there may be a workaround: create a custom admin page that doesn't include any alt_names for models. I think that should workaround Django's validation.

Edit: Reran tests for Django <= 1.10 and they passed. Further clarified testing with Django 1.11 and 2.0.

blag commented 6 years ago

I reran the tests and everything passed! I'll see what I can do about migrations.