Adding units as a valid options

coderhs / ruby_open_weather_map

A ruby wrapper for open weather map

MIT License

79 stars 52 forks source link

Adding units as a valid options #11

Closed dNitza closed 10 years ago

coderhs commented 10 years ago

Looks good to me, through we should mention in the README that the units option can be added to all the api request.

@42races What do you think of the pull request? All the test are passing at my end.

dNitza commented 10 years ago

I've updated the readme to reflect the fact that units can be used in both the Forecast and Current and added tests to make sure the right units are actually returned.

coderhs commented 10 years ago

@dNitza Thanks for updating the README and the pull request. @42races if you are fine with it, I will merge it today and release the updated version to rubygems.