search

coderhs / ruby_open_weather_map

A ruby wrapper for open weather map
MIT License
79 stars 52 forks source link

Allowing APPID param and adding integration tests. #12

Closed yonelacort closed 10 years ago

yonelacort commented 10 years ago

In order to record the requests and not do them once again any time tests are executed, VCR + Webmock it's being used.

Also api_spec.rb file updated to use recorded requests.

deepakkumarnd commented 10 years ago

@yonelacort Good work, can you update the readme with an example usage fo APPID too ? Because I took some time to figure out what APPID is :-)

yonelacort commented 10 years ago

@42races Yes sure, sorry I forgot to update the README. I just updated including how to use the api key that you get to use the API. I'll create a new pull request. Thanks!

yonelacort commented 10 years ago

Sorry, I don't need to create a new pull request :)

coderhs commented 10 years ago

Looks cool to me :heart: :+1:

coderhs commented 10 years ago

@yonelacort Thank you for the contributions, I will push the new version of the gem to rubygems tonight.

coderhs commented 10 years ago

Gem released :)

deepakkumarnd commented 10 years ago

Great

yonelacort commented 10 years ago

Great! Thanks for the implementation to you guys! ;)

El 02/09/2014, a las 15:49, Deepak Kumar notifications@github.com escribió:

Great

— Reply to this email directly or view it on GitHub.