search

coderhs / ruby_open_weather_map

A ruby wrapper for open weather map
MIT License
79 stars 52 forks source link

Support API calls for several cities #27

Closed JesseEmond closed 8 years ago

JesseEmond commented 9 years ago

As per issue #23, this adds support for the 3 API calls to get the weather for several cities at once:

These only apply to Current, so I added class methods in api.rb (SeveralCitiesClassMethods) and then extend Current to get them.

I added an optional parameter to retrieve and send_request to add the possibility to "force" a different URL than the one specified by the class (in this case, the 3 URLs are different than the usual Current base URL).

I figured I would bump up the version number to 0.12.0, as this adds to the API.

Please let me know if I should change anything or if you have ideas on how to improve this PR. Thank you!

coderhs commented 9 years ago

Had a quick look, looks good to me. I will take a detailed look tonight. @42races, can you review this pull request as well.

JesseEmond commented 9 years ago

@coderhs I was wondering if you had time to take a detailed look? Not that it is pressing, but I would rather point to this repo in my dependencies rather than my fork. No rush, merely waiting for a followup whenever you will have time. Thanks! :smile:

coderhs commented 8 years ago

@JesseEmond sorry about the delay, merging this request, and will release the new gem soon. Probably tomorrow.