search

coderifous / jquery-localize

a jQuery plugin that makes it easy to internationalize your web site.
465 stars 142 forks source link

added small tweak so that input elements which have localized titles don... #27

Closed grahams closed 11 years ago

grahams commented 11 years ago

This builds on the previous addition that allowed title localization on any element. For input elements, the localizeInputElement didn't consider that the value might be an object with value/title keys. I added a test for this.

coderifous commented 11 years ago

Hi Sean - Thanks for the pull request. You mentioned that you "added a test for this", but I don't see it in the pull request. Can you please add the test?

grahams commented 11 years ago

Sorry for the confusion, by test I meant 'testing the variable', not a unit test. I'll take a look at your unit test stuff and add one.

grahams commented 11 years ago

Wouldn't you know it, writing unit tests helped me find a bug! :) I'll submit a new pull request with the added tests and fixed bug.