search

coderifous / jquery-localize

a jQuery plugin that makes it easy to internationalize your web site.
465 stars 142 forks source link

Handle input elements with a title set #28

Closed grahams closed 11 years ago

grahams commented 11 years ago

Take two:

I tried to set the title attribute on an input element, and the value of the input element was set to '[Object object]' . Added a change to allow for keyword.value when using keyword.title on input elements to prevent this.

Also added qunit tests to test the 'classic' behavior ("keyword": "insert this value") as well as the new behavior ('keyword": { "value": "insert this value", "title": "insert this title"}').

coderifous commented 11 years ago

Thanks, Sean! I'll review this tonight.

coderifous commented 11 years ago

Sean, I squashed your commits and made some small changes, but otherwise have pulled in your changes to master and kept you as the author. Thank you for the contribution!

grahams commented 11 years ago

Glad I could help!