Most types of fields are gated so a missing key doesn't replace text with a blank, but not for spans

coderifous / jquery-localize

a jQuery plugin that makes it easy to internationalize your web site.

465 stars 142 forks source link

Most types of fields are gated so a missing key doesn't replace text with a blank, but not for spans #29

Closed AdamMcCormick closed 9 years ago

AdamMcCormick commented 11 years ago

So this adds that gating for that case

coderifous commented 11 years ago

Hi, Adam. Thanks for the pull-request. Can you please add a test for this change?

AdamMcCormick commented 11 years ago

Sure, should be done later today

coderifous commented 9 years ago

Sorry, this pull request ended up being confusing. The ticket title mentioned tags, but the code change didn't have anything to do with span tags. The tests added seemed unrelated to the code change.

The good news is that I think the essence of the issue was addressed in #37.