search

codernaut / citizenconnect

Apache License 2.0
1 stars 9 forks source link

Restrict app to only `portrait` screen mode #26

Open wahibhaq opened 6 years ago

wahibhaq commented 6 years ago

I would strongly suggest to make app only support portrait because of 2 reasons.

1) I don't see much use with landscape mode. This is a typical content (mostly lists based screen) heavy app which works perfectly with portrait mode 2) We can save ourselves from a lot of problems related to retaining state when screen is rotated. State Management in Android is not an easy thing. There are solutions possible of course but always adds an additional overhead. Considering our situation its efficient to reduce potential problems.

P.S: Currently app crashes on Services tab and you try to move from portrait -> landscape -> come back to portrait which is caused by NullPointerException in MainActivity:122. We should definitely fix this problem but also disable landscape mode.

I can handle it or even shahzaib can handle it. not a big deal!

codernaut commented 6 years ago

removing enhancement because making it both bug and enhancement is oxymoron

codernaut commented 6 years ago

and i agree its so simple that even a noob like me can do it so I will do it :D

wahibhaq commented 6 years ago

ok then :)