Bad error messages when dependencies are missing

coderobe / VBiosFinder

Extract embedded VBIOS from (almost) any BIOS Update

GNU Affero General Public License v3.0

128 stars 21 forks source link

Bad error messages when dependencies are missing #11

Open stzokev opened 5 years ago

stzokev commented 5 years ago

If I don't have innoextract I get the /var/lib/gems/2.3.0/gems/cocaine-0.5.8/lib/cocaine/command_line.rb:82:in `run': Cocaine::CommandNotFoundError (Cocaine::CommandNotFoundError)

which others have reported before. So apparently it is not optional as indicated in the instructions. Or if it is optional in some cases, a clarification might be needed.

Great tool otherwise! Thanks for your hard work!

coderobe commented 5 years ago

it's optional unless it's actually required for extraction. i should probably catch these errors and print a more helpful error message

coderobe commented 5 years ago

Specifically, though, it will tell you

checking for innoextract... no
Install 'innoextract' on your system (required for Inno Installers)

stzokev commented 5 years ago

Yes, but it gives similar error messages for all dependencies, and half of them are marked as optional. Knowing that, I just ignore these messages.