coderobe / VBiosFinder

Extract embedded VBIOS from (almost) any BIOS Update
GNU Affero General Public License v3.0
129 stars 21 forks source link

Custom saving needs improvement #20

Closed stzokev closed 3 years ago

stzokev commented 4 years ago

Whenever it cannot determine vbios type, it seems to only take into consideration the name of the image for the saved file. I've hit a case when there are multiple instances of the same name, so I end up with a single file e.g.:

can't determine vbios type of body.bin, saving as 'vbios_unknown_body.bin' can't determine vbios type of body.bin, saving as 'vbios_unknown_body.bin' can't determine vbios type of body.bin, saving as 'vbios_unknown_body.bin' can't determine vbios type of body.bin, saving as 'vbios_unknown_body.bin'

Maybe a random UUID should be used for the file name? You can reproduce this with Zbook 17 G2 bios.

coderobe commented 3 years ago

Should be fixed now