search

coderobin / AvalonEdit

The XAML-based text editor component for UWP
4 stars 3 forks source link

Rewritting #1

Closed SCKelemen closed 5 years ago

SCKelemen commented 8 years ago

In order for this to be UWP/MVVM compliant, most of this code will need to be rewritten.

xied75 commented 8 years ago

Based on my experiences on trying to get ngit work under UWP, sometimes working on the forked repo is 100 times harder than just start anew from scratch, when you are changing the targeting framework etc. In this case to adopt it to fit MVVM, which I'm not yet sure how easy is to accomplish. But let's see.

xied75 commented 8 years ago

1, Would you want me to add you as a collaborator to the repo so that you can merge PR yourself? 2, Or do you prefer that we review each other's PR and leave me to merge? 3, Any other preferences you have over work flow, GitHub flow etc.?

SCKelemen commented 8 years ago

I don't care, you can just review the code. Then, I will have another set of eyes, leading to higher code quality. I would say, move the old code into a folder. Then create a new solution, SourceEditor, and we can start anew with that for UWP/MVVM