coderofstuff / app-kaspa

Kaspa Ledger Integration
MIT License
3 stars 5 forks source link

Allow ECDSA address as output #15

Closed coderofstuff closed 1 year ago

coderofstuff commented 1 year ago

Confirmed working:

ECDSA has a different OP_CODE (0xab) so this adds support for that.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (0f85b11) 88.01% compared to head (093ed75) 88.03%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15 +/- ## ========================================== + Coverage 88.01% 88.03% +0.02% ========================================== Files 25 25 Lines 1176 1178 +2 ========================================== + Hits 1035 1037 +2 Misses 141 141 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `88.03% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/coderofstuff/app-kaspa/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unit-tests/test\_tx\_parser.c](https://codecov.io/gh/coderofstuff/app-kaspa/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dW5pdC10ZXN0cy90ZXN0X3R4X3BhcnNlci5j) | `100.00% <ø> (ø)` | | | [src/sighash.c](https://codecov.io/gh/coderofstuff/app-kaspa/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2hhc2guYw==) | `95.41% <100.00%> (ø)` | | | [src/transaction/deserialize.c](https://codecov.io/gh/coderofstuff/app-kaspa/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RyYW5zYWN0aW9uL2Rlc2VyaWFsaXplLmM=) | `65.95% <100.00%> (+1.51%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.