coderofstuff / app-kaspa

Kaspa Ledger Integration
MIT License
3 stars 5 forks source link

Support P2SH #46

Closed coderofstuff closed 1 year ago

coderofstuff commented 1 year ago

The 3rd address type you can send to is a P2SH address.

An example: kaspa:precqv0krj3r6uyyfa36ga7s0u9jct0v4wg8ctsfde2gkrsgwgw8jgxfzfc98 (devfund)

These addresses are:

Fixes #45

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 89.55% and project coverage change: +0.05 :tada:

Comparison is base (6475f5f) 93.33% compared to head (18d2b1f) 93.39%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== + Coverage 93.33% 93.39% +0.05% ========================================== Files 23 23 Lines 1231 1287 +56 ========================================== + Hits 1149 1202 +53 - Misses 82 85 +3 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `93.39% <89.55%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/sighash.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2hhc2guYw==) | `93.80% <66.66%> (-1.61%)` | :arrow_down: | | [src/address.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2FkZHJlc3MuYw==) | `93.93% <75.00%> (-2.22%)` | :arrow_down: | | [src/transaction/deserialize.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RyYW5zYWN0aW9uL2Rlc2VyaWFsaXplLmM=) | `91.42% <76.92%> (-1.91%)` | :arrow_down: | | [src/transaction/serialize.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RyYW5zYWN0aW9uL3NlcmlhbGl6ZS5j) | `100.00% <100.00%> (ø)` | | | [src/transaction/utils.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RyYW5zYWN0aW9uL3V0aWxzLmM=) | `100.00% <100.00%> (ø)` | | | [unit-tests/test\_address.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dW5pdC10ZXN0cy90ZXN0X2FkZHJlc3MuYw==) | `100.00% <100.00%> (ø)` | | | [unit-tests/test\_tx\_parser.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dW5pdC10ZXN0cy90ZXN0X3R4X3BhcnNlci5j) | `100.00% <100.00%> (ø)` | | | [unit-tests/test\_tx\_utils.c](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dW5pdC10ZXN0cy90ZXN0X3R4X3V0aWxzLmM=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/coderofstuff/app-kaspa/pull/46/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

coderofstuff commented 1 year ago

Send to P2SH: https://explorer.kaspa.org/txs/e8a7f889ab0a1d3ce560245c65b2c3a002445034fc71632a7a3cdc54754dcf88

Send to Schnorr: https://explorer.kaspa.org/txs/a3a25c622d287552db6c5b3d81e3838c4a7d7f1e969cda3b02f4e720cd5e7195

Send to ECDSA: https://explorer.kaspa.org/txs/8fe76222138fe5189b8b58cb7e7b8df4f697f7ec44bc80b6bfd37f2931e0122b