coders-camp-2021-best-team / TeamUp-Client

GNU General Public License v3.0
4 stars 1 forks source link

feat: Add `CreatePost` screen #52

Closed maciejopalinski closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for teamup-client ready!

Name Link
Latest commit 3da46ca029a46aafd8cf90c8f4003fc1f8d6cf82
Latest deploy log https://app.netlify.com/sites/teamup-client/deploys/62653d0f3b05f0000889a39e
Deploy Preview https://deploy-preview-52--teamup-client.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maciejopalinski commented 2 years ago

What components? I just copied login screen that you approved. Bruh. Do we really have time for that?

On Sun, Apr 24, 2022, 1:55 PM Cyprian Zamiara @.***> wrote:

@.**** approved this pull request.

In src/screens/CreatePost.tsx https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#discussion_r857114575 :

+import { useCreatePost } from '../Api/EndPoints/useCreatePost'; +import { useUploadAttachment } from '../Api/EndPoints/useUploadAttachment'; +import { theme } from '../config/theme'; +import { ROUTES } from '../routes/Routes'; +import { CreatePost as CreatePostDTO } from '../utils/types/apiTypes'; + +export const CreatePost = () => {

  • const { handleSubmit, register } = useForm<
  • CreatePostDTO & { files: FileList }
  • ();

  • const createPost = useCreatePost();
  • const uploadAtt = useUploadAttachment();
  • const navigate = useNavigate();
  • return (
  • <div

it's MUI, don't use just div tag

In src/screens/CreatePost.tsx https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#discussion_r857114713 :

  • }}
  • <Typography
  • component='h1'
  • variant='h4'
  • color='common.white'
  • sx={{
  • fontSize: '24px'
  • }
  • }}
  • Create New Post
  • <form

use components from MUI

— Reply to this email directly, view it on GitHub https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#pullrequestreview-951194533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXEWMQOPA4ELY6HCJH3ENLVGUZERANCNFSM5UFIRTEA . You are receiving this because you authored the thread.Message ID: @.*** com>

Veryyapeee commented 2 years ago

What components? I just copied login screen that you approved. Bruh. Do we really have time for that?

On Sun, Apr 24, 2022, 1:55 PM Cyprian Zamiara @.***> wrote:

@.**** approved this pull request.

In src/screens/CreatePost.tsx https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#discussion_r857114575 :

+import { useCreatePost } from '../Api/EndPoints/useCreatePost'; +import { useUploadAttachment } from '../Api/EndPoints/useUploadAttachment'; +import { theme } from '../config/theme'; +import { ROUTES } from '../routes/Routes'; +import { CreatePost as CreatePostDTO } from '../utils/types/apiTypes'; + +export const CreatePost = () => {

  • const { handleSubmit, register } = useForm<
  • CreatePostDTO & { files: FileList }
  • ();

  • const createPost = useCreatePost();
  • const uploadAtt = useUploadAttachment();
  • const navigate = useNavigate();
  • return (
  • <div

it's MUI, don't use just div tag

In src/screens/CreatePost.tsx https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#discussion_r857114713 :

  • }}
  • <Typography
  • component='h1'
  • variant='h4'
  • color='common.white'
  • sx={{
  • fontSize: '24px'
  • }
  • }}
  • Create New Post
  • <form

use components from MUI

— Reply to this email directly, view it on GitHub https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#pullrequestreview-951194533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXEWMQOPA4ELY6HCJH3ENLVGUZERANCNFSM5UFIRTEA . You are receiving this because you authored the thread.Message ID: @.*** com>

Yeah, we dont, thats why I approved that anyways

maciejopalinski commented 2 years ago

Ok

On Sun, Apr 24, 2022, 1:59 PM Cyprian Zamiara @.***> wrote:

What components? I just copied login screen that you approved. Bruh. Do we really have time for that?

On Sun, Apr 24, 2022, 1:55 PM Cyprian Zamiara @.***> wrote:

@.**** approved this pull request.

In src/screens/CreatePost.tsx

52 (comment)

https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#discussion_r857114575 :

+import { useCreatePost } from '../Api/EndPoints/useCreatePost'; +import { useUploadAttachment } from '../Api/EndPoints/useUploadAttachment'; +import { theme } from '../config/theme'; +import { ROUTES } from '../routes/Routes'; +import { CreatePost as CreatePostDTO } from '../utils/types/apiTypes';

-

+export const CreatePost = () => {

  • const { handleSubmit, register } = useForm<

  • CreatePostDTO & { files: FileList }

  • ();

  • const createPost = useCreatePost();

  • const uploadAtt = useUploadAttachment();

  • const navigate = useNavigate();

  • return (

  • <div

it's MUI, don't use just div tag

In src/screens/CreatePost.tsx

52 (comment)

https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#discussion_r857114713 :

-

          }}

-

      >

-

          <Typography

-

              component='h1'

-

              variant='h4'

-

              color='common.white'

-

              sx={{

-

                  [theme.breakpoints.down('tablet')]: {

-

                      fontSize: '24px'

-

                  }

-

              }}

-

          >

-

              Create New Post

-

          </Typography>

-

          <form

use components from MUI

— Reply to this email directly, view it on GitHub

52 (review)

https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#pullrequestreview-951194533 , or unsubscribe

https://github.com/notifications/unsubscribe-auth/AKXEWMQOPA4ELY6HCJH3ENLVGUZERANCNFSM5UFIRTEA . You are receiving this because you authored the thread.Message ID: @.*** com>

Yeah, we dont, thats why I approved that anyways

— Reply to this email directly, view it on GitHub https://github.com/coders-camp-2021-best-team/TeamUp-Client/pull/52#issuecomment-1107826383, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXEWMSY4MOVT2XVEEKOUBDVGUZSLANCNFSM5UFIRTEA . You are receiving this because you authored the thread.Message ID: @.***>