search

coders-school / desktop-business-app

0 stars 4 forks source link

resolve #11 #13

Closed mBialczak closed 7 months ago

mBialczak commented 7 months ago
  1. physically removed "bin" directory from repo
  2. added "bin" directory to .gitignore
  3. updated Dockerfile in order to have ready-accessible built UT target via docker
  4. Removed explicit unit-test step: RATIONALE: there is no longer a pre-built bin directory so the step would fail. The docker build image already contains UT run, so there is no additional need to run tests separately. image
mBialczak commented 7 months ago

Do we accept unit-test step removal and is docker file ut-run enough for us? If not, I could use some help to resolve the problem of building the binary on CI, running tests, as I faced some problems with that. In such case DO NOT ACCEPT THE PULL REQUEST (until discussed and approved)

ziobron commented 7 months ago

Thanks @fbtom for Code Review. 🏅 1 XP granted

ziobron commented 7 months ago

Your PR was merged! 🏅 2 XP granted. Thanks @mBialczak for making course materials better!

ziobron commented 7 months ago

Thanks @BaqWin for Code Review. 🏅 1 XP granted