search

coders-school / lambdas

GNU General Public License v3.0
0 stars 75 forks source link

Update Catch2 #58

Closed arafalski closed 2 years ago

ziobron commented 2 years ago

And what is being changed? Is it a formatting change or bump to a newer version?

ziobron commented 2 years ago

If this is a formatting issue because clang-format fails, please add a new option to formatting-check job to exclude some directories and pass it here.

arafalski commented 2 years ago

Clang-format action already ignores catch2 files. It's just an update to the newest stable version of catch2 framework. I wasn't able to compile the old one.

ziobron commented 2 years ago

Clang-format action already ignores catch2 files. It's just an update to the newest stable version of catch2 framework. I wasn't able to compile the old one.

Ok, so please put such information in the commit and PR description in future

ziobron commented 2 years ago

Your PR was merged! 🏅 2 XP granted. Thanks @anraf1001 for making course materials better!