Please review, I think it's better than "feature/pw-entry".
This approach tries to keep authentication and authentication data out of business code, wherever possible. I think, doing it this direction helps keeping the code maintainable.
If there's anything missing or wrong (e.g. routing configuration), feel free to add commits to feature branch (had to force push, so delete locally before fetching again).
Note the changes to ".po" - done for en_US and de_DE. If there's a more appropriate text, I'd be happy about corrections.
Additionally we might need some clarification of what's show in which count:
count("unverified" numbers) <= 18 + count("verified" (authenticated entered) numbers) <= 18?
(merged into one sorted set, so total number might be <36)
Or a total max of 18? If so: do "verified" overrule "unverified" and if there's already 18+ verified no unverified (no matter if count >= 3) is shown?
I'd vote the former, and therefore implemented the merge solution. But it should be easy to modify algorithm, if rules are made clear.
pitpalme
commented
9 years ago
Please review, I think it's better than "feature/pw-entry". This approach tries to keep authentication and authentication data out of business code, wherever possible. I think, doing it this direction helps keeping the code maintainable.
If there's anything missing or wrong (e.g. routing configuration), feel free to add commits to feature branch (had to force push, so delete locally before fetching again).
Note the changes to ".po" - done for en_US and de_DE. If there's a more appropriate text, I'd be happy about corrections. Additionally we might need some clarification of what's show in which count:
count("unverified" numbers) <= 18 + count("verified" (authenticated entered) numbers) <= 18? (merged into one sorted set, so total number might be <36)
Or a total max of 18? If so: do "verified" overrule "unverified" and if there's already 18+ verified no unverified (no matter if count >= 3) is shown?
I'd vote the former, and therefore implemented the merge solution. But it should be easy to modify algorithm, if rules are made clear.