search

coders51 / rabbitmq-stream-js-client

rabbitmq-stream-js-client
MIT License
34 stars 5 forks source link

Add support for EXTERNAL auth #213

Closed david-mohr closed 3 weeks ago

david-mohr commented 3 months ago

Adds an optional mechanism parameter and implements EXTERNAL auth following the Java reference implementation.

Also fixes a broken test.

icappello commented 3 months ago

Hello, thanks for opening this PR! We will give you a feedback in the next few days

david-mohr commented 2 months ago

Just about to head on vacation, so I will be able to make these updates in a few weeks.

david-mohr commented 4 weeks ago

Is there a way I can run these github actions on my own account? I have not used github actions before, so not familiar with them. Plus I seem to be in a different timezone making it challenging to work on it while you are available.

icappello commented 4 weeks ago

Hello David, I think you need to enable Actions in your forked repository by visiting the "Actions" tab. You should see a warning with a button to enable workflows.

Here is a discussion regarding this https://github.com/orgs/community/discussions/50736

Thanks again!

david-mohr commented 4 weeks ago

Thanks for the pointers, the workflow should now be working as expected.

icappello commented 4 weeks ago

We'll give you a feedback as soon as possible.

Thanks!

gpad commented 3 weeks ago

@david-mohr Thank for the PR I have added two small comments. WDYT about it?

david-mohr commented 3 weeks ago

@gpad thanks, updates applied

david-mohr commented 1 week ago

@icappello just curious, do you have an eta on the next release? Happy using my fork for now, but wanted to follow up before I forget. Thanks!