Open schulzad opened 6 years ago
look like https://github.com/codersaur/SmartThings/pull/20 might also fix the null value error. I can rebase off that if need be.
Is this being maintained anymore? If not, can you add me to this repo or fork the influxdb stuff to another repo so we can get some of these changes in?
@codersaur I'm one of the SmartThings developers (as is @schulzad). Several of the core team use this integration and really enjoy it. This patch is fairly important for correct operations with a large number of devices as otherwise the softPoll generates an HubAction for each configured device. If a large number of things are configured, this results in dropped requests as the cloud has a max queue depth for LAN messages to the hub.
These errors are not exposed directly to users as the queue depth restriction is handled by a different edge service managing the connections with the hub but you can see a pretty clear 5 minute spike of errors for my home setup due to the softPoll capping out the LAN queue. This can also affect other LAN automations that may be doing something more important than syncing data to influx.
This PR collapses down all of the requests that would happen on softPoll down to a single HTTP request which keeps this from being a problem. Please let us know if you have any questions.
Did you guys think about creating an active fork or something? Seems abandoned here.
Did you guys think about creating an active fork or something? Seems abandoned here.
Unfortunately the way the licensing is setup, this cannot be forked and maintained. At least not officially.