I140 make leaderboard page

[HuxleyBerry]

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

• Added a total_mileage field to the user and team models
  • If you achieve some mileage and then join a team, the already achieved mileage does not go towards your team's total. However, once you join the team, all mileage you achieve from then on will be counted.
• Added signals to respond to any updating, creating or deleting mileage model instances by modifying the total_mileage field accordingly
  • This could have been done in the post_mileage view instead, but the advantage of using signals is that the total_mileage field will also be updated if the admin messes with users' mileage
• Added a view in the backend to calculate the user and team leaderboards (just the top 100). If a user or team is passed with the request, the individual ranking of the passed user/team is also calculated (even if they're not in the top 100)
• Made the leaderboard page on the frontend. It's pretty similar to the design on figma

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

• [x] The pull request title has an issue number
• [x] The change works by "Smoke testing" or quick testing
• [ ] The change has tests
• [ ] The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related Issue

• Resolve #140

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stride-for-education	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 2:02pm

[ChantelleKerr]

Might have to merge main into your branch. You could change how you get the total mileage since you have it stored in the user table

[HuxleyBerry]

Might have to merge main into your branch. You could change how you get the total mileage since you have it stored in the user table

Hmm, so calling get_mileage() for every user rather than simply accessing the total_mileage field? The latter option should be a lot more efficient I think.

[ChantelleKerr]

Might have to merge main into your branch. You could change how you get the total mileage since you have it stored in the user table

Hmm, so calling get_mileage() for every user rather than simply accessing the total_mileage field? The latter option should be a lot more efficient I think.

Yeah I agree, the graph PR didnt have a total_mileage field so yours works well i think :)

[HuxleyBerry]

However, in the teams case, there is the potential for there to be a discrepancy between the value of total_mileage in the team model, and the sum value obtained by get_mileage(). This is because total_mileage doesn't count mileage achieved before a user joined the team, whereas get_mileage() does. So for consistency, maybe get_mileage() should return the value of total mileage in this case. We wouldn't want the total km value in the team dashboard to be different to what is shown on the leaderboard. The downside to this is that the total implied by the team mileage graph wouldn't match with the total given in the team dashboard. Not sure what to best thing to do is...

[HuxleyBerry]

Perhaps the solution is for the mileage model to have a nullable team field, which records the team (if any) the user was in when the mileage was achieved. I think that will fix everything

...assuming that what we want to do is only count mileage achieved when the user is part of the team

[HuxleyBerry]

Think I'm done now