user now knows error

[makon1234]

Change Summary

Team name already taken error more descriptive

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

• [x] The pull request title has an issue number
• [x] The change works by "Smoke testing" or quick testing
• [ ] The change has tests
• [ ] The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related Issue

• Resolve #261

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stride-for-education	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2023 7:37am

[HuxleyBerry]

You'll also get an error if you try to submit a very long team name (over 254 characters). It doesn't make sense for the error to say that the team name is already taken in this case. I think you'll need to show different error messages depending on the value of error.reponse.data. Also, you could keep the original generic error message, and make it show when none of the particular errors occur. That way, the user will still see that an error occurred if some weird error occurs (e.g. an internal server error).

[makon1234]

Do you think I should try and create a limit of the number of characters the team name can have

[makon1234]

also, is it okay if I ignore the yarn type-check errors?

[HuxleyBerry]

Nice, though you can replace error.response !== undefined with simply error.response, since undefined is falsy

[HuxleyBerry]

Looks good to me

[makon1234]

Thanks, I will wait for Chantelle to give the all clear