search

codersforcauses / elucidate

Documentation: https://elucidate-project-documentation.readthedocs.io/en/latest/
https://elucidate-production.up.railway.app/
MIT License
9 stars 1 forks source link

chore(deps): update dependency urllib3 to v1.26.19 [security] #218

Open renovate[bot] opened 1 year ago

renovate[bot] commented 1 year ago

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
urllib3 (changelog) ==1.26.10 -> ==1.26.19 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-43804

urllib3 doesn't treat the Cookie HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify a Cookie header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.

Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the Cookie header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.

Affected usages

We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:

Remediation

CVE-2023-45803

urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.

From RFC 9110 Section 9.3.1:

A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.

Affected usages

Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.

Both of the following conditions must be true to be affected by this vulnerability:

Remediation

You can remediate this vulnerability with any of the following steps:

CVE-2024-37891

When using urllib3's proxy support with ProxyManager, the Proxy-Authorization header is only sent to the configured proxy, as expected.

However, when sending HTTP requests without using urllib3's proxy support, it's possible to accidentally configure the Proxy-Authorization header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat the Proxy-Authorization HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects.

Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the Proxy-Authorization header during cross-origin redirects to avoid the small chance that users are doing this on accident.

Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the Proxy-Authorization header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach.

Affected usages

We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:

Remediation

Release Notes

urllib3/urllib3 (urllib3) ### [`v1.26.19`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12619-2024-06-17) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.18...1.26.19) \==================== - Added the `Proxy-Authorization` header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via `Retry.remove_headers_on_redirect`. - Fixed handling of OpenSSL 3.2.0 new error message for misconfiguring an HTTP proxy as HTTPS. (`#​3405 `\__) ### [`v1.26.18`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12618-2023-10-17) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.17...1.26.18) \==================== - Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses. ### [`v1.26.17`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12617-2023-10-02) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.16...1.26.17) \==================== - Added the `Cookie` header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via `Retry.remove_headers_on_redirect`. (`#​3139 `\_) ### [`v1.26.16`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12616-2023-05-23) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.15...1.26.16) \==================== - Fixed thread-safety issue where accessing a `PoolManager` with many distinct origins would cause connection pools to be closed while requests are in progress (`#​2954 `\_) ### [`v1.26.15`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12615-2023-03-10) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.14...1.26.15) \==================== - Fix socket timeout value when `HTTPConnection` is reused (`#​2645 `\__) - Remove "!" character from the unreserved characters in IPv6 Zone ID parsing (`#​2899 `\__) - Fix IDNA handling of '\x80' byte (`#​2901 `\__) ### [`v1.26.14`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12614-2023-01-11) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.13...1.26.14) \==================== - Fixed parsing of port 0 (zero) returning None, instead of 0. (`#​2850 `\__) - Removed deprecated getheaders() calls in contrib module. Fixed the type hint of `PoolKey.key_retries` by adding `bool` to the union. (`#​2865 `\__) ### [`v1.26.13`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12613-2022-11-23) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.12...1.26.13) \==================== - Deprecated the `HTTPResponse.getheaders()` and `HTTPResponse.getheader()` methods. - Fixed an issue where parsing a URL with leading zeroes in the port would be rejected even when the port number after removing the zeroes was valid. - Fixed a deprecation warning when using cryptography v39.0.0. - Removed the `<4` in the `Requires-Python` packaging metadata field. ### [`v1.26.12`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12612-2022-08-22) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.11...1.26.12) \==================== - Deprecated the `urllib3[secure]` extra and the `urllib3.contrib.pyopenssl` module. Both will be removed in v2.x. See this `GitHub issue `\_ for justification and info on how to migrate. ### [`v1.26.11`](https://redirect.github.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12611-2022-07-25) [Compare Source](https://redirect.github.com/urllib3/urllib3/compare/1.26.10...1.26.11) \==================== - Fixed an issue where reading more than 2 GiB in a call to `HTTPResponse.read` would raise an `OverflowError` on Python 3.9 and earlier.

Configuration

πŸ“… Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.

This PR was generated by Mend Renovate. View the repository job log.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
elucidate-frontend βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 18, 2024 3:04am
codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.31%. Comparing base (b56d674) to head (c11d368).

:exclamation: Current head c11d368 differs from pull request most recent head 2ee2b18

Please upload reports for the commit 2ee2b18 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #218 +/- ## ======================================= Coverage 83.31% 83.31% ======================================= Files 47 47 Lines 1139 1139 ======================================= Hits 949 949 Misses 190 190 ``` | [Flag](https://app.codecov.io/gh/codersforcauses/elucidate/pull/218/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codersforcauses) | Coverage Ξ” | | |---|---|---| | [backend](https://app.codecov.io/gh/codersforcauses/elucidate/pull/218/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codersforcauses) | `83.31% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codersforcauses#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.