273 ability to mark vet concerns and incidents as resolved

codersforcauses / poops

A progressive web app to help volunteers track their volunteering activities, register vet concerns and log incident reports. Documentations: https://codersforcauses.github.io/poops

https://poops.vercel.app/

MIT License

23 stars 5 forks source link

273 ability to mark vet concerns and incidents as resolved #279

Closed justinliangg closed 1 year ago

justinliangg commented 1 year ago

Change Summary

Added a button to allow vet concerns and incidents to be resolved.
Changed query to only display unresolved vet concerns and incidents

Change Form

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
poops	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 22, 2023 at 2:57PM (UTC)

justinliangg commented 1 year ago

@scratchclaggy

Everything looks good to me, but I'm having trouble testing it. I'm guessing you've confirmed it works as exprected? Also some conflicts to clear up here before the final approval.

You're right, I just tested it on the preview and it doesn't seem to be working. I think it has something to do with having a query on multiple fields, which requires indexing? I've fixed it by moving the filtering for unresolved statuses to the client side, let me know if this would be an issue.