Issue 109 get endpoint to get repairers for an event

codersforcauses / repair-lab

https://repair-labs.vercel.app

MIT License

8 stars 3 forks source link

Issue 109 get endpoint to get repairers for an event #173

Closed tonglam closed 9 months ago

tonglam commented 10 months ago

Change Summary

Create a GET /api/event/{eventId}/repairers endpoint
Create unit test for the endpoint

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[x] The change has tests
[ ] The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

tonglam commented 10 months ago

⚠ Duplicate page detected. src/pages/api/event/[id]/repairers.ts and src/pages/api/event/[id]/repairers/index.ts resolve to /api/event/[id]/repairers

======================= I find out there is another issue add an new enpoint, but the name is same as issue #109, so the pages will be duplicated. I think we need to change one of these names, or merge the codes in one file.

justinliangg commented 10 months ago

⚠ Duplicate page detected. src/pages/api/event/[id]/repairers.ts and src/pages/api/event/[id]/repairers/index.ts resolve to /api/event/[id]/repairers

======================= I find out there is another issue add an new enpoint, but the name is same as issue #109, so the pages will be duplicated. I think we need to change one of these names, or merge the codes in one file.

Yes, you will need to merge them together. Should be able to POST and GET repairers on /event/:eventId/repairers endpoint