search

codership / galera

Synchronous multi-master replication library
GNU General Public License v2.0
451 stars 176 forks source link

SSL compression not enabled even with socket.ssl_compression=YES #297

Open philip-galera opened 9 years ago

philip-galera commented 9 years ago

Even with socket.ssl_compression=YES, compression does not seem to be enabled:

2015-06-26 18:15:25 45232 [Note] WSREP: SSL handshake successful, remote endpoint ssl://127.0.0.1:58084 local endpoint ssl://127.0.0.1:13001 cipher: AES128-SHA compression:

Also, both openssl s_client and sslyze report that no compression is being used on the connection.

philip-galera commented 9 years ago

It seems that SSL_COMP_add_compression_method is not being used and should be called on both sides of the connection.

nirbhayc commented 9 years ago

Boost-1.54 disabled ssl compression by default, and it has to be explicitly turned on.

http://www.boost.org/users/history/version_1_54_0.html : Changed ssl::context to automatically disable SSL compression by default. To enable, use the new ssl::context::clear_options() function, as in my_context.clear_options(ssl::context::no_compression).

nirbhayc commented 9 years ago

I would also suggest to print "No" or "None" if compression isn't available.

matiskiba commented 9 years ago

Hello,

I tried to implement the compression support, both by clearing the option, and by adding compression method. My changes can be found here: https://github.com/matiskiba/galera/commits/25.3.12

However it still does not work. Moreover, the code: COMP_METHOD *comp_method; comp_method = COMP_zlib(); log_info << "compression name: " << (comp_method->name != NULL? comp_method->name:""); Yields Nov 11 04:56:25 ubuntu mysqld: 151111 4:56:25 [Note] WSREP: compression name: (undef)

Which seems to indicate a build/configuration issue?

Would be great if you could offer a direction.

Kind regards, Mati Skiba

vlasky commented 3 years ago

I am also experiencing this issue and cannot enable SSL compression. I am using Percona XtraDB Cluster 8.0.23-14.1, WSREP version 26.4.3. Is there a fix?