search

coderxio / dailymed-api

REST API for DailyMed SPLs
https://coderx.io/
MIT License
12 stars 5 forks source link

Actions poetry venv refactor #43

Closed yevgenybulochnik closed 4 years ago

yevgenybulochnik commented 4 years ago

Explanation

I adjusted how the venv gets setup in actions. Instead of using pyenv to setup the venv for application code, I refactored the action to mimic what is being done in docker. Only issues with this is apparently there is a bug in poetry with flake8 for python version < 3.8 which is causing the build to error out for python 3.7.9. I think we should consider simply using python 3.8 and refactoring docker to use this as well.

Rationale

I think this makes for a slightly cleaner action setup and removes the dependency on pyenv.

Tests

  1. What testing did you do?
    • see relevant action build log for pushes to this branch
finish06 commented 4 years ago

Flake8 is failing on the Python 3.7 code. Looks like the package was adjusted between Python 3.7 & Python 3.8. The naming may have changed, i.e. importlib_metadata to importlib-metadata. Still need to do more investigation.

I think Poetry metadata is set to Python 3.8. This may be the problem considering it appears the package in some way changed between 3.7 & 3.8.

yevgenybulochnik commented 4 years ago

So attempted to adjust this to support python 3.9 but appears one of the deps doesnt support 3.9 lxml which was causing the build to fail on 3.9. Adjusted the branch to only include 3.8 for now. Actually after further investigation, there are many libs that dont support 3.9, its just too new it seems. This includes scrapy and django.