feat: solve second run failure

coderxio / sagerx

Open drug data pipelines curated by pharmacists.

https://coderx.io/sagerx

Other

41 stars 11 forks source link

feat: solve second run failure #260

Closed RiversPharmD closed 3 months ago

RiversPharmD commented 4 months ago

Resolves #258

Explanation

Implemented Drop Cascade

Rationale

Tried the suggested TRUNCATE approach, did not work. DROP CASCADE works with appropriate downstream view quality.

Tests

What testing did you do? Currently running full DAG, but ran with 10 rows and 1000 rows to test speed and quality.

Below screenshot show manually triggered DAG with 1000 rows of the historical NDCS being used.

jrlegrand commented 3 months ago

@lprzychodzien - did you implement this type of fix in one of the PRs you submitted recently? I think so but I can't remember exactly. Maybe we can close this PR?

lprzychodzien commented 3 months ago

Yes added cascade logic here

jrlegrand commented 3 months ago

@lprzychodzien implemented this idea from @RiversPharmD in a different PR, but credit goes to @RiversPharmD for testing and ruling out other options.