codes-org / codes

The Co-Design of Exascale Storage Architectures (CODES) simulation framework builds upon the ROSS parallel discrete event simulation engine to provide high-performance simulation utilities and models for building scalable distributed systems simulations
Other
40 stars 16 forks source link

bgp io language - variable names restricted to single character (Imported #114) #114

Closed nmcglo closed 5 years ago

nmcglo commented 8 years ago

Original Issue Author: Jonathan Jenkins Original Issue ID: 114 Original Issue URL: https://xgitlab.cels.anl.gov/codes/codes/issues/114


The lexer treats each individual character as a token. The symbol table is simply an 26-element array of counters, one for each letter of the alphabet. Additionally, the errors when multi-character variables are used (asides from the keywords e.g. writeall) are cryptic and don't really help.

Input files are attached. Here is an output dump:

john@jtop:bin$ ./codes-workload-dump --type=bgp_io_workload --num-ranks=1 --i-meta=test_meta_ok.txt --i-rank-cnt=1 --i-use-relpath --i-bgp-config=blah loading bgp_io_workload, 0 op: rank:0 type:write file_id:0 off:0 size:2 op: rank:0 type:close file_id:0 op: rank:0 type:end

john@jtop:bin$ ./codes-workload-dump --type=bgp_io_workload --num-ranks=1 --i-meta=test_meta_error.txt --i-rank-cnt=1 --i-use-relpath --i-bgp-config=blah loading bgp_io_workload, 0 1 error = syntax error, unexpected VARIABLE 1 error = syntax error, unexpected '=', expecting $end op: rank:0 type:open file_id:0 flag:1 1 error = syntax error, unexpected VARIABLE op: rank:0 type:write file_id:0 off:0 size:0 1 error = syntax error, unexpected ',', expecting $end op: rank:0 type:close file_id:0 op: rank:0 type:end

nmcglo commented 8 years ago

Jonathan Jenkins:

Status changed to closed

nmcglo commented 8 years ago

Jonathan Jenkins:

Since we aren't planning on changing this, we simply need to make sure the downside is documented somewhere then we can close this.

nmcglo commented 8 years ago

Jonathan Jenkins:

Documenting...

nmcglo commented 8 years ago

Jonathan Jenkins:

Test cases