search

codes-org / codes

The Co-Design of Exascale Storage Architectures (CODES) simulation framework builds upon the ROSS parallel discrete event simulation engine to provide high-performance simulation utilities and models for building scalable distributed systems simulations
Other
40 stars 16 forks source link

dragonfly using torus internal data structures (Imported #87) #87

Closed nmcglo closed 4 years ago

nmcglo commented 8 years ago

Original Issue Author: Jonathan Jenkins Original Issue ID: 87 Original Issue URL: https://xgitlab.cels.anl.gov/codes/codes/issues/87

Because we expose network impl info in public headers (#125), the dragonfly model uses an event data structure internal to the torus model, specifically the "nodes_message" struct, and in a possibly incorrect manner - D_COLLECTIVE_FAN_OUT is seemingly invalidly converted to another enum type. Is this expected/correct behavior? Should we refactor the torus data structure so it is properly shared?

nmcglo commented 8 years ago

Jonathan Jenkins:

In addition to this, we should designate the torus/dragonfly based collective implementation as deprecated. We plan to have a new collective implementation (most probably at the MPI Sim layer or model-net layer).

nmcglo commented 4 years ago

FYI: I think he meant to reference #84

nmcglo commented 4 years ago

This looks like it's been addressed. Closing