codesandbox / codesandbox-client

An online IDE for rapid web development
https://codesandbox.io
Other
13.07k stars 2.28k forks source link

Manifest Error when Exporting default CRA template #2016

Open karlhorky opened 5 years ago

karlhorky commented 5 years ago

🐛 bug report

Description of the problem

Because there is no manifest.json file in the default create-react-app template (related to #1532), exporting and running yarn start gives the Manifest: Line: 1, column: 1, Unexpected token. error because HTML is getting served instead of JSON.

Screen Shot 2019-06-04 at 00 55 25 Screen Shot 2019-06-04 at 00 55 49 Screen Shot 2019-06-04 at 00 56 05

How has this issue affected you? What are you trying to accomplish?

Export + yarn start default CRA template without browser console errors.

Link to sandbox:

https://codesandbox.io/s/new

Your Environment

Software Name/Version
Сodesandbox PROD-1559409667-1cce2689
Browser Chrome stable
Operating System macOS 10.14.5
Saeris commented 5 years ago

Simple explanation here is that our create-react-app template is not a 1;1 clone of the official create react app starter files, so that would be the source of this bug.

We're looking to address this in an upcoming overhaul of templates on the platform. Thanks for reporting this and we'll address it as soon as possible!

For now all I can offer as a solution is to add the missing files that create react app expects yourself when attempting to run the code on your local machine. We can't retroactively add missing files to Sandboxes forked from the existing React template without running the risk of overwriting a user's changes.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

karlhorky commented 4 years ago

@Saeris was the manifest ever added here?

github-actions[bot] commented 3 years ago

This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

karlhorky commented 3 years ago

not stale

github-actions[bot] commented 3 years ago

This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

karlhorky commented 3 years ago

asdf

github-actions[bot] commented 3 years ago

This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

karlhorky commented 3 years ago

bot