codesandbox / codesandbox-client

An online IDE for rapid web development
https://codesandbox.io
Other
13.1k stars 2.28k forks source link

%20 in GitHub urls no longer seems to be converted to + #6109

Closed Haroenv closed 3 years ago

Haroenv commented 3 years ago

🐛 bug report

Preflight Checklist

Description of the problem

%20 (and presumably other parameters) no longer get transformed to + correctly to be read

How has this issue affected you? What are you trying to accomplish?

have to edit the url after submitting

To Reproduce

this doesn't work: (changed github.com with https://codesandbox.io/s/github as I usually do)

https://codesandbox.io/s/github/algolia/doc-code-samples/tree/master/Vue%20InstantSearch/server-side-rendering

this works:

https://codesandbox.io/s/github/algolia/doc-code-samples/tree/master/Vue+InstantSearch/server-side-rendering

Link to sandbox: [link]() (optional)

Your Environment

Software Name/Version
Сodesandbox 8e4ea7567
Browser Safari
Operating System macOS Big Sur 11.5.2 (20G95)
lbogdan commented 3 years ago

Hey @Haroenv ,

Do you know if this worked before? I'm assuming yes, as you said "no longer", but just wanted to make sure. If so, do you have an estimate of when it stopped working?

Haroenv commented 3 years ago

I definitely remember that it used to work up to maybe a month or two ago?

sannek commented 3 years ago

Hi - Thanks for reporting!

I'm pretty sure I know what introduced this, so I'm going to have a look at fixing it right now. (It's a backend issue - so you won't se a PR here, but I'll be back to let you know / close this issue when the fix is live)

lbogdan commented 3 years ago

The fix was merged, but it's not deployed just yet.

sannek commented 3 years ago

Just deployed - so should be all good again 🎉

Haroenv commented 3 years ago

Thanks for being so quick @lbogdan and @sannek, those URLs seem to work for me!