codesandbox / codesandbox-client

An online IDE for rapid web development
https://codesandbox.io
Other
13.08k stars 2.28k forks source link

Stuck: At project creation, cant exit or login #7014

Closed gregg-cbs closed 2 years ago

gregg-cbs commented 2 years ago

🐛 bug report

Preflight Checklist

Description of the problem

On project creation and choosing a start project/template I am getting an error to login but it is not possible for me to do that because I cant exit the create project screen.

How has this issue affected you? What are you trying to accomplish?

Trying to create a server project but cannot because I need to be logged in.

To Reproduce

Go to https://codesandbox.io , scroll a little and click 'get started for free', in the template search, search for 'Nuxt 3', click any nuxt template to start and notice the errors at the bottom of your screen. Now assume you want to login or get away from this template choosing screen... how do you?

Video recording of incident

https://user-images.githubusercontent.com/57114335/195291000-56a8d1df-de4a-4093-b950-4c885c2f93be.mp4

Your Environment

Software Name/Version
Сodesandbox browser
Browser firefox
Operating System windows
tristandubbeld commented 2 years ago

Hey @gregg-cbs, once again thanks for reporting an issue :)

We're discussing on how to improve the UX by e.g. showing the sign in button in the Cloud templates tab and the notification; I'll try to get started on this ASAP. In the meantime you should be able to login through the "Import form GitHub" tab. There's a login button there. Thanks again for your help, we really appreciate it!

gregg-cbs commented 2 years ago

No problem, i am happy to help and report. Glad its received well. Look forward to seeing the update.

tristandubbeld commented 2 years ago

The changes should be live @gregg-cbs. We're showing a sign in button in the notification as well as in more tabs. Thanks again for your feedback!

gregg-cbs commented 2 years ago

I see its live, thanks for making that update but theres a spot you missed.

Because you are sometimes showing the sign in button in the notification and other times in the templates modal tab content (like on the Cloud templates tab), then sometimes you dont see the sign in button at all.

"Quick start" tab -> "NextJS" template... no login button: image

I think you should put the login button next to the search input so you dont have multiple login buttons and cases where it might not exist. Also that kind of encourages sign ins. image

or I was originally expecting to see it in the side nav like this: image

tristandubbeld commented 2 years ago

You're right! I was unaware of a change that happened when checking if we should show a sign in button on the error message. I've created a PR to make sure we show a sign in button in the error message again.

"Quick start" tab -> "NextJS" template... no login button:

Since it's not required to sign in for non-beta templates we don't show a sign in button on every tab. The cloud templates tab requires the user to sign in to create a cloud sandbox (for now). As a "quick convenience" I've added it there because there are no "anonymous user templates" in that tab.

I think you should put the login button next to the search input [...]

or I was originally expecting to [...]

Yep good suggestions, we're looking into the best way to tackle this. I'll discuss if this is something we want and if it doesn't disrupt future plans.