codesandbox / codesandbox-client

An online IDE for rapid web development
https://codesandbox.io
Other
12.96k stars 2.26k forks source link

Changing 'lib' compiler option to 'es2017' has no effect #8427

Closed MitchelSt closed 2 months ago

MitchelSt commented 2 months ago

🐛 bug report

Preflight Checklist

Description of the problem

How has this issue affected you? What are you trying to accomplish?

To Reproduce

  1. Open sendbox, check error on line 16 under .values: Property 'values' does not exist on type 'ObjectConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2017' or later.typescript(2550)
  2. Go to the tsconfig.json file
  3. => BUG: version is set to es2017 but the error is still showing

Link to sandbox: https://t.ly/Xu4E0

Your Environment

Software Name/Version
Сodesandbox Mar 31, 2024
Browser Chrome 123
Operating System macOS (Sonoma)
CompuIves commented 2 months ago

Hmm, looks like our in-browser TS is not working correctly. I'll take a look at fixing this. In the meantime it should work correctly in a devbox.

steveluscher commented 2 months ago

This and #8433 are quite probably related.

CompuIves commented 2 months ago

Not exactly, but I do know what's causing this now! I will create a fix for this today, probably deploy tomorrow.