search

codesandbox / dependency-packager

Other
238 stars 62 forks source link

GitHub Dependency: prepare script ignored #2

Closed dahlbyk closed 6 years ago

dahlbyk commented 6 years ago

I'm trying to use CodeSandbox to verify a fix by installing a dependency directly from a GitHub branch. I've traced the error back to this project:

Could not fetch dependencies, please try again in a couple seconds: Something went wrong while packaging the dependency griddle-react@GriddleGriddle/Griddle#my-branch: ENOENT: no such file or directory, scandir '/tmp/1532470022/node_modules/griddle-react/dist/module'

The package's prepare script is not being executed, probably due to --ignore-scripts?

https://github.com/codesandbox-app/dependency-packager/blob/544b6357c8ac60f6bcb3084527015ade2dafe7a2/functions/packager/dependencies/install-dependencies.ts#L16

I'm wondering if --ignore-scripts is necessary, or perhaps should be avoided for Git/GitHub versions?

CompuIves commented 6 years ago

Hmm, we did the ignore-scripts because of security reasons, but since we're running on serverless functions nowadays I think it's safe to remove. I'll remove it now!

CompuIves commented 6 years ago

Live now!

dahlbyk commented 6 years ago

Hrm, still not working. Are you using a version of yarn that supports prepare for GitHub dependencies?

For reference, this is the sandbox I'm using to test: https://codesandbox.io/s/nkq0wrz1jl.

CompuIves commented 6 years ago

Ah, I'm sorry for that! I accidentally deployed to staging instead of prod. Deploying to prow now.